Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to preview 1 release #14485

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Update SDK to preview 1 release #14485

merged 3 commits into from
Feb 15, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 14, 2024

>   /__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.arcade.sdk/9.0.0-beta.24106.2/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/__w/1/s/artifacts/sb/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj]
mmitche
mmitche previously approved these changes Feb 14, 2024
@ViktorHofer ViktorHofer merged commit 89008f3 into dotnet:main Feb 15, 2024
15 checks passed
mikem8361 pushed a commit to dotnet/diagnostics that referenced this pull request Feb 21, 2024
@@ -13,6 +13,7 @@
<IsShipping>false</IsShipping>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
<RepositoryUrl>https://github.com/dotnet/arcade</RepositoryUrl>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmat I wonder what changed that made this necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error looked like this (for multiple projects):

/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.arcade.sdk/9.0.0-beta.24106.2/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/__w/1/s/artifacts/sb/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dotnet/sourcelink@0647320 caused this but am not 100% sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it's actually a different change. See discussion in dotnet/runtime#98476 (comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer See #14487 (comment)

I think the issue is that the inner clone isn't propagating the remotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants