-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to preview 1 release #14485
Conversation
@@ -13,6 +13,7 @@ | |||
<IsShipping>false</IsShipping> | |||
<EnableNETAnalyzers>true</EnableNETAnalyzers> | |||
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | |||
<RepositoryUrl>https://github.com/dotnet/arcade</RepositoryUrl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmat I wonder what changed that made this necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error looked like this (for multiple projects):
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.arcade.sdk/9.0.0-beta.24106.2/tools/Workarounds.targets(79,5): error : PackageProjectUrl must be specified [/__w/1/s/artifacts/sb/src/src/Microsoft.DotNet.Arcade.Sdk/Microsoft.DotNet.Arcade.Sdk.csproj]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dotnet/sourcelink@0647320 caused this but am not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK it's actually a different change. See discussion in dotnet/runtime#98476 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer See #14487 (comment)
I think the issue is that the inner clone isn't propagating the remotes.
cc @ViktorHofer, @mmitche